search

florinpop17 / app-ideas

A Collection of application ideas which can be used to improve your coding skills.
https://iCodeThis.com/?ref=app-ideas
MIT License
80.93k stars 9.6k forks source link

fixes-issue #870 #871

Open shivamsawarn2003 opened 1 month ago

shivamsawarn2003 commented 1 month ago

Budget tracker app 1.)Create your own user profiles 2.)secured with jwt authentication 3.)Allows users to track their regular transactions including description section their to know where they have used their expenses and when including time and date of transaction 4.)All these expenses will be saved in our database securely. Fixes #870

shivamsawarn2003 commented 1 month ago

Hi, I have submitted a new idea for the Budget Tracker app. Could you please add the "new idea" label to this pull request? Thank you!

Git-Harshit commented 1 month ago

Hi @shivamsawarn2003, I have a general comment for your changes in this PR. Please exclude node_modules folder from your changes. As you may have seen, the difference for this PR is very huge due to node_modules contents which are present in your commit. As your application under the 'backend' folder contains a package.json for all of the npm package details, anyone using your source can do a npm install to setup node_modules at their end, and node_modules unnecessarily bulk the source with their library files which may not always work on another machine with the same matching folder. You can refer https://stackoverflow.com/questions/63294260/what-is-the-purpose-of-the-node-modules-folder for more information. So, you can remove node_modules from your PR.

Please also note that I am not a maintainer or reviewer of this project, and have considered providing this comment in general. You may correct the diff. in your PR for reviewability, then wait for a reviewer or request one of them to review your changes.