search

florisluiten / rssreader

RSS Reader
MIT License
5 stars 3 forks source link

add --local-content-can-access-remote-urls flag #12

Closed balcy closed 6 years ago

balcy commented 6 years ago

without that the chromium web security does not let the local app (file:///) access the feed urls

see https://github.com/ubports/morph-browser/issues/44

add clickable.json and .gitignore

florisluiten commented 6 years ago

Hi balcy,

First of all, I apologize for my late response, for I had disabled e-mail notifications for this repo and did not see your PR.

Thank you for your time and effort to look into this, it look promising. However, since I have not actively been working on this projects for quite some time I'm not sure how to test it ATM.

I have to setup my development machine from scratch before I can start working on this PR and look into how I even got the to be accepted in the first place. Also I'm not quite sure whether my approach of using a HTML+JavaScript to build an app is still supported. I'm leaving this PR open so I'm reminded about it once I got my development machine running again.

Thanks again!

balcy commented 6 years ago

Hi floris, that's fine, I'm glad the project is not yet abandoned : ) What I can say is that the HTML apps are still supported (now instead of Oxide Ubports used QtWebengine as backend, which is also based on chromium) I've already tested the change and it is working...

Nowadays via the tool clickable (http://clickable.bhdouglass.com/en/latest/) it is possible to built the click packages in a docker container it provides

Hint: If you use the following clickable file: { "template":"pure", "dependencies":["morph-webapp-container", "morph-browser"] } you can run it locally via clickable desktop (for me the second run worked)

florisluiten commented 6 years ago

Hi balcy,

Thanks again for your help; I had no luck installing the Ubuntu SDK at all so I tried the clickable package and it works like a charm.

I also merged your pull request, after I made some changes to make it running for clickable. This now lives in a seperate branch called clickable. I'm hoping to do some more changes in that branch and will be merging it into the master branch (and deploy a new version on ubports) when I feel confident that all still works as expected.

balcy commented 5 years ago

Hi Floris, wanted to say that with the upcoming OTA6 without the flag it will no longer be possible to add and update feeds.