florrain / locale

Browser locale negotiation for node.js
MIT License
257 stars 36 forks source link

Instance default by @VaclavObornik , merged to Master #35

Closed rhagigi closed 8 years ago

rhagigi commented 8 years ago

Credit to @VaclavObornik, I just merged this and updated the tests to match the other existing tests (in terms of which languages are used, other than the default), and I included the lib changes from prepublish.

Original PR #20.

Fixes #27 Fixes #26

@jed @florrain

florrain commented 8 years ago

Thanks @rhagigi for jumping onto this!!

I'm a bit preoccupied by the merge commit here, not sure how hard it would be to rebase instead of merge but I'd rather see the work rebased on top of master + squashed into one commit before it's actually merged as you suggested on the other thread. Otherwise 👍