search

florrain / locale

Browser locale negotiation for node.js
MIT License
257 stars 36 forks source link

Plz support definition for typescript users #46

Open webhacking opened 5 years ago

webhacking commented 5 years ago

I could not use it at all because of one of my compilation options So I made it myself. I hope others don't have the same issues as me.

import { Locale } from 'locale';

export declare module 'locale' {
  interface Locale {
    code: string;
    language: string;
    country: string;
    normalized: string;
    score: number;
  }
  declare function Locales(language: string): Locale[];
}
florrain commented 5 years ago

Hi there, I don't use TypeScript at all but is there anything the repo could include to better support it?

I'm guessing your snippet is fixing it, but can you describe what it is solving. And two would you be up for a PR?

forivall commented 5 years ago

You can also submit a PR to https://github.com/DefinitelyTyped/DefinitelyTyped/

forivall commented 4 years ago

I wrote one https://github.com/DefinitelyTyped/DefinitelyTyped/pull/42968