search

flosch / pongo2

Django-syntax like template-engine for Go
https://www.schlachter.tech/pongo2
MIT License
2.86k stars 269 forks source link

Potential BC break on master (missing var comparison) #341

Open Richtermeister opened 9 months ago

Richtermeister commented 9 months ago

The following expression has changed results between v6.0.0 and current master branch:

{{ _missing == null }}

Given no parameters. v6.0.0 output: True master output: False

In understand that null does not have a special meaning in pongo, but I imagine these expressions are out in the wild, and flipping the evaluation would be quite unexpected, so wanted to flag this as potential BC break.

I suspect this is the commit that changed the behavior: https://github.com/flosch/pongo2/commit/2ef5c88f6016044f1e054562b114347b3a27b071

Thank you for your time.