floss-fund / portal

Portal / directory for listing, indexing, and crawling funding.json manifests
https://dir.floss.fund
GNU Affero General Public License v3.0
21 stars 6 forks source link

`too many lines in the .well-known list` when directory is not at the root level in repo #11

Closed reknih closed 1 week ago

reknih commented 2 weeks ago

We would like to place the .well-known directory with the funding-manifest-urls in a subfolder of our repository, next to GitHub's related FUNDING.yml file. When doing so, submitting our page fails with the error too many lines in the .well-known list.

We have placed the funding-manifest-urls here: https://github.com/typst/typst/blob/main/.github/.well-known/funding-manifest-urls, https://github.com/typst/pdf-writer/blob/main/.github/.well-known/funding-manifest-urls, etc.

Our funding.json can be found at https://typst.app/funding.json.

Relatedly, our funding-manifest-urls contain the customary trailing line break. Does it need to be removed for spec compliance?

knadh commented 2 weeks ago

Ah, GitHub URLs return HTML views (hence too many lines). We've added a hack for pulling the raw files for first-level GitHub URLs. Will have to tweak this to allow URLs at any level of nesting: https://github.com/floss-fund/go-funding-json/blob/d9d4a988c7b8e56223287423ce2ed3b5ec743931/common/http.go#L35

Will fix and update here.

Relatedly, our funding-manifest-urls contain the customary trailing line break. Does it need to be removed for spec compliance?

This doesn't matter.

reknih commented 2 weeks ago

Ah, GitHub URLs return HTML views (hence too many lines).

I suspected that this might have something to do with the problem. Thanks for taking care of it and for creating FLOSS/Fund!

knadh commented 1 week ago

This is fixed and the listing is live: https://dir.floss.fund/view/@typst.app