Closed domengasperlin closed 6 months ago
Thank you!!
still saying the same issue in https://github.com/Homebrew/homebrew-core/pull/158728
==> /opt/homebrew/Cellar/sloc/0.3.1/bin/sloc --format=csv .
/opt/homebrew/Library/Homebrew/ignorable.rb:29:in `block in raise'
Minitest::Assertion: --- expected
+++ actual
@@ -1,3 +1,18 @@
-"Path,Physical,Source,Comment,Single-line comment,Block comment,Mixed,Empty block comment,Empty,To Do
-Total,4,4,0,0,0,0,0,0,0
+"
+---------- Result ------------
+
+ Physical : 4
+ Source : 4
+ Comment : 0
+ Single-line comment : 0
+ Block comment : 0
+ Mixed : 0
+ Empty block comment : 0
+ Empty : 0
+ To Do : 0
+
+Number of files read : 1
+
+----------------------------
+
"
Updated readdirp compatibility
Problem
The current version of readdirp in the codebase is 3.3.0. However, due to a series of breaking changes readdirp introduced during the transition from version 2.x to 3.x, current implementation does not function as expected when running on directories. However it still works when running on single files. In this PR i aim to restored the functionality.
Example:
Solution
In response to this issue, the code has been adapted to ensure compatibility with readdirp version 3.x. The changes align with the specifications outlined in the readdirp changelog.
✅ tests 80 passing (55ms)
✅ linter
✅ built and ran the generated cli to verify it now works as expected in comparison to not working before.