Closed domengasperlin closed 6 months ago
Thx!
Let me know if I should create a release :)
Let me know if I should create a release :)
Please yes, test output now also matches the one from brew
Can we cut a pre-release or release for testing? There is no clean way to apply this PR change.
Just bumping this - a release would be really helpful because the tool is currently completely broken.
Just bumping this - a release would be really helpful because the tool is currently completely broken.
sure :+1: Should be online now.
It seems release is failing due to failing test here https://github.com/Homebrew/homebrew-core/pull/158728
The test is checking if sloc works with csv format option https://github.com/Homebrew/homebrew-core/blob/171e50bca163025fd40fde21629cc667da49c77c/Formula/s/sloc.rb#L23
Options functionality was broken with commander v7.0.0 release.
From migration guide for commander lib
Use the .opts() method to access the options. This is available on any command but is used most with the program. Details: https://github.com/tj/commander.js/releases/tag/v7.0.0
Result
This change restores back command options
version, exclude, include, format, format-option, strip-colors
. So all the options work again.