search

flosse / sloc

simple tool to count SLOC (source lines of code)
MIT License
945 stars 83 forks source link

Logo #38

Closed stevenvachon closed 9 years ago

stevenvachon commented 9 years ago

Closes #37

Important Files

File Name Description
logo-full.svg For editing.
logo-min.svg For production use -- minified and most self-documenting ids removed.
logo.png For production use on crappy sites that don't allow SVG

Extra Files

File Name Description
logo.ai Original drawing. I only included this because the filters used in the .svg files would not display correctly in my old version of Illustrator when I needed to export the .png
logo.icns, logo.ico Mac/Windows icon files for possible future use. I'd already made them and didn't want to throw them away
flosse commented 9 years ago

Great! But as you already know, I'd like to add only one source ;-) So I'd only include logo-full.svg and logo.icns/logo.ico. I'll have a look at its source (svg file, because I prefer to use open applications like inkscape).

stevenvachon commented 9 years ago

I would still recommend keeping logo-min.svg and logo.png as they are production files.

I can understand omitting logo.ai if logo-full.svg displays correctly in Inkscape.

Idea: how about merging this with all files followed by another PR removing logo.ai? If we ever need it in the future for whatever reason, there's at least a backup.

tomByrer commented 9 years ago

there's at least a backup.

I'm not a git expert, but won't that 'deleted' file be downloaded in every future clone also?

I'm using Inkscape v0.91pre2 r13516 as we speak; seems nice so far, & one minor bug|confusion I found was easily fixed by copy-pasting an XML segment from another part of the SVG.

stevenvachon commented 9 years ago

I'm not a git expert, but won't that 'deleted' file be downloaded in every future clone also?

Yes, but it's just one ~900kb file in git history. I doubt there'd be many more like this.

one minor bug|confusion I found was easily fixed by copy-pasting an XML segment from another part of the SVG

Which segment?

tomByrer commented 9 years ago

Which segment?

I was messing with layers & blending modes for some of the objects, & either Inkscape or I got confused. For some reason, one of the blending modes makes the object invisible when I exported the minified version & viewed in a browser.

stevenvachon commented 9 years ago

@tomByrer it must be an Inkscape bug because if the SVG was invalid, no browser would render it. Also, SVGO minified it without issue.

tomByrer commented 9 years ago

Maybe a bug; don't have time to troubleshoot. v0.91 has decent built-in compression; Save-As..., dropdown: Optimized SVG. Uses another python script that was popular for a while.