search

flossmanualsfr / escoria

MIT License
38 stars 10 forks source link

Unrecognised binary resource file error(s) with PNM files. #9

Open Sslaxx opened 8 years ago

Sslaxx commented 8 years ago

As of the latest Git Godot build (probably with 2.1 and earlier as well, but not checked), netpbm files give unrecognised binary resource file error messages, e.g. with res://scenes/intro-game/sprites/click_mask/bad_bamboo_click_mask.pbm. Also "Condition err!=OK is true. Returned RES()".

Sslaxx commented 8 years ago

This may also affect other files, for example I saw it return similar error messages with Speex files (although I understand support for that might have changed or been dropped?).

Sslaxx commented 8 years ago

Interestingly though, at least one pnm file does appear to be genuinely broken.

res://scenes/intro-game/sprites/click_mask/look_click_mask.pbm

nylnook commented 7 years ago

I can confirm....

nylnook commented 6 years ago

That's probably a blocking element in #12 too, I'll try to convert .pnm files to a more widespread format like .png

nylnook commented 6 years ago

I tried to fix that with dcc372e142248a46f066ca46a1bf1c4121821ccb, but it appear that Godot do not accept any other format than PBM for a click mask and that seem to be an easily corruptible format, despite I tried to export both with Gimp and Imagemagick.

As far as I understand, in a PBM file, data can be binary or ASCII, but there is no way to know which one is expected by Godot.

So for me this is upstream...

nylnook commented 6 years ago

This is mostly fixed upstream : https://github.com/godotengine/godot/issues/15524 We have to wait for Godot 3.1 ;)