search

flother / spreet

Create a spritesheet from a set of SVG images
MIT License
81 stars 4 forks source link

Hide implementation details with module structure #75

Closed nyurik closed 10 months ago

nyurik commented 10 months ago

For a relatively small crate like this, I think it is unnecesary verbose to use nested repeated identifiers like spreet::error::SpreetError. Instead, I propose to move all the crate-defined IDs to the root like spreet::SpreetError. The only exception is the resvg because it represents a big crate itself.

nyurik commented 10 months ago

I patched Martin to use this PR - to see what changes one would have to do to use the new API, including the simpler use pattern. https://github.com/maplibre/martin/pull/984

flother commented 10 months ago

Makes sense, thanks.

This needs an item in the CHANGELOG (formatted like this) because this is a breaking change. As far as I know no-one but you is using Spreet as a library, but best practices etc.

nyurik commented 10 months ago

thx, done

nyurik commented 10 months ago

when do you plan the next release?

flother commented 10 months ago

I have a half-finished PR for #58 that I'd like to include in the next release, so my plan (such that it is) is to wait on that