flourishlib / flourish-classes

The class files for Flourish
http://flourishlib.com
182 stars 78 forks source link

Fix infinite loop issue with non-closed connections #217

Open julien731 opened 9 years ago

julien731 commented 9 years ago

With some server configurations (I couldn't tell what exactly), the problem of the infinite loop caused by the use of feof() with a connection opened with fsockopen() and not being closed by the server as explained on the PHP manual page of the function happens. This results in the process not being completed, the e-mails aren't checked and it can actually lead to a 504 error.

In order to fix that, I have replaced the while loop by a do {} while(); so that the end of the resource $this->connection is actually processed and the correct value is returned, allowing the function to continue its process.