flovilmart / cocoapods-mix-frameworks

Mix Frameworks and static libs!
MIT License
17 stars 0 forks source link

Need update for CP 1.4.0 #5

Open bpoplauschi opened 6 years ago

bpoplauschi commented 6 years ago

Hi @flovilmart. First of all, very nice plugin, super useful to avoid the app startup performance issues when using many dynamic frameworks.

The issue I encountered is the demo project doesn't work with the latest CocoaPods 1.4.0. If I run against CP 1.3.1, everything is ok.

With CP 1.4.0:

error when compiling AppDelegate.swift: no such module Moya.

Commenting the import Moya line, I get a linker error:

ld: framework not found Alamofire
clang: error: linker command failed with exit code 1 (use -v to see invocation)
flovilmart commented 6 years ago

Can you provide an example podfile?

bpoplauschi commented 6 years ago

@flovilmart I'm talking about the example project on this repo. The podfile:

plugin 'cocoapods-mix-frameworks'
mix_frameworks

platform :ios, '10.3'

target 'CocoaPods-Mix-Demo' do
  pod 'Fabric'
end

target 'CocoaPods-Mix-Framework' do
    use_frameworks!
    pod 'Moya'
end

target 'CocoaPods-Mix-Action' do
    use_frameworks!
    pod 'Moya'
end

Just try it with CP 1.4.0

flovilmart commented 6 years ago

@bpoplauschi I just tried and there's no issue that I can reproduce with cocoapods 1.4.0. App is launching and compiling fine.

bpoplauschi commented 6 years ago

@flovilmart I just retried. Same error.

Xcode Version 9.2 (9C40b)
Mac OS Sierra 10.12.6 (16G1114)
CocoaPods 1.4.0
git clone git@github.com:flovilmart/cocoapods-mix-frameworks.git
pod install (inside CocoaPods-Mix-Demo folder)
Xcode build

Error:

CompileSwift normal x86_64 /Users/bogdanp/GitHub/cocoapods-mix-frameworks/example/CocoaPods-Mix-Demo/CocoaPods-Mix-Demo/AppDelegate.swift
    cd /Users/bogdanp/GitHub/cocoapods-mix-frameworks/example/CocoaPods-Mix-Demo
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift -frontend -c /Users/bogdanp/GitHub/cocoapods-mix-frameworks/example/CocoaPods-Mix-Demo/CocoaPods-Mix-Demo/ViewController.swift -primary-file /Users/bogdanp/GitHub/cocoapods-mix-frameworks/example/CocoaPods-Mix-Demo/CocoaPods-Mix-Demo/AppDelegate.swift -target x86_64-apple-ios10.3 -enable-objc-interop -sdk /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator11.2.sdk -I /Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Products/Debug-iphonesimulator -F /Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Products/Debug-iphonesimulator -F /Users/bogdanp/GitHub/cocoapods-mix-frameworks/example/CocoaPods-Mix-Demo/Pods/Fabric/iOS -enable-testing -g -module-cache-path /Users/bogdanp/Library/Developer/Xcode/DerivedData/ModuleCache -swift-version 3 -enforce-exclusivity=checked -D DEBUG -D COCOAPODS -serialize-debugging-options -report-errors-to-debugger -Xcc -I/Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Intermediates.noindex/CocoaPods-Mix-Demo.build/Debug-iphonesimulator/CocoaPods-Mix-Demo.build/swift-overrides.hmap -Xcc -iquote -Xcc /Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Intermediates.noindex/CocoaPods-Mix-Demo.build/Debug-iphonesimulator/CocoaPods-Mix-Demo.build/CocoaPods-Mix-Demo-generated-files.hmap -Xcc -I/Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Intermediates.noindex/CocoaPods-Mix-Demo.build/Debug-iphonesimulator/CocoaPods-Mix-Demo.build/CocoaPods-Mix-Demo-own-target-headers.hmap -Xcc -I/Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Intermediates.noindex/CocoaPods-Mix-Demo.build/Debug-iphonesimulator/CocoaPods-Mix-Demo.build/CocoaPods-Mix-Demo-all-non-framework-target-headers.hmap -Xcc -ivfsoverlay -Xcc /Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Intermediates.noindex/CocoaPods-Mix-Demo.build/all-product-headers.yaml -Xcc -iquote -Xcc /Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Intermediates.noindex/CocoaPods-Mix-Demo.build/Debug-iphonesimulator/CocoaPods-Mix-Demo.build/CocoaPods-Mix-Demo-project-headers.hmap -Xcc -I/Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Products/Debug-iphonesimulator/include -Xcc -I/Users/bogdanp/GitHub/cocoapods-mix-frameworks/example/CocoaPods-Mix-Demo/Pods/Headers/Public -Xcc -I/Users/bogdanp/GitHub/cocoapods-mix-frameworks/example/CocoaPods-Mix-Demo/Pods/Headers/Public/Fabric -Xcc -I/Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Intermediates.noindex/CocoaPods-Mix-Demo.build/Debug-iphonesimulator/CocoaPods-Mix-Demo.build/DerivedSources/x86_64 -Xcc -I/Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Intermediates.noindex/CocoaPods-Mix-Demo.build/Debug-iphonesimulator/CocoaPods-Mix-Demo.build/DerivedSources -Xcc -DDEBUG=1 -Xcc -DCOCOAPODS=1 -Xcc -working-directory/Users/bogdanp/GitHub/cocoapods-mix-frameworks/example/CocoaPods-Mix-Demo -emit-module-doc-path /Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Intermediates.noindex/CocoaPods-Mix-Demo.build/Debug-iphonesimulator/CocoaPods-Mix-Demo.build/Objects-normal/x86_64/AppDelegate~partial.swiftdoc -serialize-diagnostics-path /Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Intermediates.noindex/CocoaPods-Mix-Demo.build/Debug-iphonesimulator/CocoaPods-Mix-Demo.build/Objects-normal/x86_64/AppDelegate.dia -Onone -module-name CocoaPods_Mix_Demo -emit-module-path /Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Intermediates.noindex/CocoaPods-Mix-Demo.build/Debug-iphonesimulator/CocoaPods-Mix-Demo.build/Objects-normal/x86_64/AppDelegate~partial.swiftmodule -emit-dependencies-path /Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Intermediates.noindex/CocoaPods-Mix-Demo.build/Debug-iphonesimulator/CocoaPods-Mix-Demo.build/Objects-normal/x86_64/AppDelegate.d -emit-reference-dependencies-path /Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Intermediates.noindex/CocoaPods-Mix-Demo.build/Debug-iphonesimulator/CocoaPods-Mix-Demo.build/Objects-normal/x86_64/AppDelegate.swiftdeps -o /Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Build/Intermediates.noindex/CocoaPods-Mix-Demo.build/Debug-iphonesimulator/CocoaPods-Mix-Demo.build/Objects-normal/x86_64/AppDelegate.o -index-store-path /Users/bogdanp/Library/Developer/Xcode/DerivedData/CocoaPods-Mix-Demo-fipilnlybgozwkcmqjoxzjgyzmti/Index/DataStore -index-system-modules

/Users/bogdanp/GitHub/cocoapods-mix-frameworks/example/CocoaPods-Mix-Demo/CocoaPods-Mix-Demo/AppDelegate.swift:11:8: error: no such module 'Moya'
import Moya
       ^

Try cleaning everything (delete Derived Data + Pods folder and redo pod install).