search

flow-hydraulics / flow-pds

This repository is currently not maintained
4 stars 8 forks source link

Sadie/secure cadence upgrade #148

Closed sadief closed 2 years ago

sadief commented 2 years ago

We need to update the flow-pds to use the following versions due to some breaking changes incoming for Cadence.

github.com/onflow/cadence v0.21.3-0.20220422215834-5ba7ff3666fd
github.com/onflow/flow-cli v0.33.2-0.20220425184358-8797257ba650
github.com/onflow/flow-go-sdk v0.24.1-0.20220421152843-9ce4d554036e

The main Cadence upgrade changes are fixing a few functions from the SDK which have changed function signature (eg. cadence.NewString() which now produces an error), as well as updating the smart contracts.

NOTE This only works right now with this version of go-with-the-flow: https://github.com/flow-hydraulics/go-with-the-flow/pull/1

It's currently pointed at my local branch as I had to make changes, but need some assistance on that PR first

judezhu commented 2 years ago

Hi @sadief, thanks for the upgrade! we are working on a fork repo here: https://github.com/dapperlabs/flow-pds. So this repo has the latest code. Do you wanna update here and we can port over the changes to this repo later?

sadief commented 2 years ago

Closing in favour of: https://github.com/dapperlabs/flow-pds/pull/19