flow-php / flow

Flow PHP - data processing framework
https://flow-php.com
MIT License
404 stars 23 forks source link

Adjust Inflection to run only on changed files #1073

Closed stloyd closed 1 month ago

stloyd commented 1 month ago

Change Log

Added

Fixed

Changed

  • Adjust Inflection to run only on changed files

Removed

Deprecated

Security


Description

Using new feature from https://github.com/infection/infection/pull/1919 to not run Inflection against whole codebase, but only on the changed files.

norberttech commented 1 month ago

don't we need to add also #CoversClass in order to make it work?

stloyd commented 1 month ago

Unfortunately yes... so we cannot bring this improvement...

github-actions[bot] commented 1 month ago

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors ```shell +-----------------------+-------------------+------+-----+------------------+------------------+-----------------+ | benchmark | subject | revs | its | mem_peak | mode | rstdev | +-----------------------+-------------------+------+-----+------------------+------------------+-----------------+ | AvroExtractorBench | bench_extract_10k | 1 | 3 | 35.422mb +0.00% | 826.011ms +1.06% | ±0.69% +249.04% | | CSVExtractorBench | bench_extract_10k | 1 | 3 | 5.142mb +0.00% | 337.761ms -0.14% | ±2.67% +360.17% | | JsonExtractorBench | bench_extract_10k | 1 | 3 | 5.173mb +0.00% | 1.074s -1.21% | ±0.42% -82.21% | | ParquetExtractorBench | bench_extract_10k | 1 | 3 | 135.845mb +0.00% | 920.569ms +0.33% | ±1.36% +506.48% | | TextExtractorBench | bench_extract_10k | 1 | 3 | 4.933mb +0.00% | 36.479ms +1.22% | ±1.11% +20.83% | | XmlExtractorBench | bench_extract_10k | 1 | 3 | 4.939mb +0.00% | 447.443ms +1.69% | ±1.57% +524.36% | +-----------------------+-------------------+------+-----+------------------+------------------+-----------------+ ```
Transformers ```shell +-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+ | benchmark | subject | revs | its | mem_peak | mode | rstdev | +-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+ | RenameEntryTransformerBench | bench_transform_10k_rows | 1 | 3 | 116.239mb +0.00% | 59.959ms -2.79% | ±0.61% -2.44% | +-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+ ```
Loaders ```shell +--------------------+----------------+------+-----+------------------+------------------+----------------+ | benchmark | subject | revs | its | mem_peak | mode | rstdev | +--------------------+----------------+------+-----+------------------+------------------+----------------+ | AvroLoaderBench | bench_load_10k | 1 | 3 | 96.807mb +0.00% | 450.807ms -0.46% | ±0.66% -46.27% | | CSVLoaderBench | bench_load_10k | 1 | 3 | 55.220mb +0.00% | 70.937ms +0.25% | ±0.52% -57.97% | | JsonLoaderBench | bench_load_10k | 1 | 3 | 107.593mb +0.00% | 51.807ms -4.43% | ±0.64% +17.09% | | ParquetLoaderBench | bench_load_10k | 1 | 3 | 227.013mb +0.00% | 1.423s -1.34% | ±0.30% +19.26% | | TextLoaderBench | bench_load_10k | 1 | 3 | 17.976mb +0.00% | 38.601ms -2.86% | ±0.47% -78.88% | +--------------------+----------------+------+-----+------------------+------------------+----------------+ ```
Building Blocks ```shell +-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+ | benchmark | subject | revs | its | mem_peak | mode | rstdev | +-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+ | RowsBench | bench_chunk_10_on_10k | 2 | 3 | 87.059mb +0.00% | 3.723ms -1.90% | ±2.06% +32.44% | | RowsBench | bench_diff_left_1k_on_10k | 2 | 3 | 102.657mb +0.00% | 189.860ms -1.65% | ±0.52% -55.91% | | RowsBench | bench_diff_right_1k_on_10k | 2 | 3 | 85.377mb +0.00% | 19.203ms -0.85% | ±1.65% +55.44% | | RowsBench | bench_drop_1k_on_10k | 2 | 3 | 88.299mb +0.00% | 1.982ms +1.76% | ±2.54% -17.37% | | RowsBench | bench_drop_right_1k_on_10k | 2 | 3 | 88.299mb +0.00% | 1.935ms -1.86% | ±0.58% -74.36% | | RowsBench | bench_entries_on_10k | 2 | 3 | 85.411mb +0.00% | 2.659ms -8.34% | ±0.22% -88.03% | | RowsBench | bench_filter_on_10k | 2 | 3 | 85.940mb +0.00% | 18.084ms -3.68% | ±0.45% -79.72% | | RowsBench | bench_find_on_10k | 2 | 3 | 85.940mb +0.00% | 18.835ms +3.22% | ±1.69% +14.61% | | RowsBench | bench_find_one_on_10k | 10 | 3 | 83.845mb +0.00% | 1.706μs -5.54% | ±2.72% +5.77% | | RowsBench | bench_first_on_10k | 10 | 3 | 83.845mb +0.00% | 0.400μs 0.00% | ±0.00% 0.00% | | RowsBench | bench_flat_map_on_1k | 2 | 3 | 93.194mb +0.00% | 12.733ms -7.41% | ±1.59% -47.12% | | RowsBench | bench_map_on_10k | 2 | 3 | 122.565mb +0.00% | 61.034ms -2.01% | ±0.50% -74.22% | | RowsBench | bench_merge_1k_on_10k | 2 | 3 | 86.460mb +0.00% | 1.496ms -1.77% | ±1.04% -66.15% | | RowsBench | bench_partition_by_on_10k | 2 | 3 | 89.807mb +0.00% | 66.003ms -3.23% | ±1.94% +89.72% | | RowsBench | bench_remove_on_10k | 2 | 3 | 88.562mb +0.00% | 4.288ms +4.69% | ±1.64% +30.65% | | RowsBench | bench_sort_asc_on_1k | 2 | 3 | 83.988mb +0.00% | 39.059ms -0.29% | ±0.93% +38.85% | | RowsBench | bench_sort_by_on_1k | 2 | 3 | 83.989mb +0.00% | 38.787ms +0.68% | ±0.61% -53.93% | | RowsBench | bench_sort_desc_on_1k | 2 | 3 | 83.988mb +0.00% | 39.025ms -2.62% | ±0.62% -70.21% | | RowsBench | bench_sort_entries_on_1k | 2 | 3 | 86.286mb +0.00% | 7.445ms +0.47% | ±0.99% +177.94% | | RowsBench | bench_sort_on_1k | 2 | 3 | 83.845mb +0.00% | 29.306ms +1.80% | ±1.26% +105.10% | | RowsBench | bench_take_1k_on_10k | 10 | 3 | 83.845mb +0.00% | 13.706μs -2.94% | ±0.34% -89.20% | | RowsBench | bench_take_right_1k_on_10k | 10 | 3 | 83.845mb +0.00% | 16.394μs -3.02% | ±0.29% -87.75% | | RowsBench | bench_unique_on_1k | 2 | 3 | 102.659mb +0.00% | 190.784ms -2.22% | ±0.94% +44.08% | | NativeEntryFactoryBench | bench_entry_factory | 1 | 3 | 116.789mb +0.00% | 496.574ms +0.12% | ±0.94% +7.55% | | NativeEntryFactoryBench | bench_entry_factory | 1 | 3 | 60.267mb +0.00% | 248.089ms -3.35% | ±0.41% -66.20% | | NativeEntryFactoryBench | bench_entry_factory | 1 | 3 | 15.201mb +0.00% | 54.105ms -1.02% | ±1.06% +108.91% | | TypeDetectorBench | bench_type_detector | 1 | 3 | 59.975mb +0.00% | 429.934ms -7.76% | ±1.19% -61.10% | | TypeDetectorBench | bench_type_detector | 1 | 3 | 14.514mb +0.00% | 92.640ms +6.26% | ±3.23% +669.41% | +-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+ ```
norberttech commented 1 month ago

could you leave the other adjustments, like using max cores? I was going to add that but there is always something more important on my plate

norberttech commented 1 month ago

@stloyd maybe there is an option to automate that https://github.com/rectorphp/rector-phpunit/pull/319#issue-2204576592