flow-storm / flow-storm-debugger

A debugger for Clojure and ClojureScript with some unique features.
The Unlicense
674 stars 29 forks source link

Flowstorm debugger should set a proper WM_CLASS #170

Open agzam opened 4 months ago

agzam commented 4 months ago

xprop WM_CLASS currently reports WM_CLASS(STRING) = "java", "java". That makes it slightly more difficult to incorporate the app into X11 and various window manager workflows.

jpmonettas commented 4 months ago

Currently you have _NET_WM_NAME(UTF8_STRING) = "FlowStorm debugger" which I use with i3 wm for example. You can customize it you start the UI with :

(fs-api/local-connect {:title "MyFlowStorm"})

Do you think it is enough or is there a reason to still prefer a JVM property to customize the class ?

agzam commented 4 months ago

The title often is not enough as some window managers customize window behavior based on the WM class. But please, don't worry about it, if I get bandwidth for this, I'll send a PR. The issue is for my own sake and for general posterity. I do sometimes go over the issues I filed in various OSS projects and see if I can provide a fix.

jpmonettas commented 4 months ago

Great, thanks @agzam, I would appreciate a PR for it if you think it is useful.