flow-storm / flow-storm-debugger

A debugger for Clojure and ClojureScript with some unique features.
The Unlicense
673 stars 30 forks source link

JavaFX applications fail to build with Maven 3.9.7 #174

Open danielsz opened 3 months ago

danielsz commented 3 months ago

Just a heads up about a nasty problem with Maven 3.9.7.

Property replacement in dependency pom no longer works

JavaFx POM was invalid since 2021 and only worked "by chance". See here.

Solution is to upgrade JavaFX to 23-ea+20.

jpmonettas commented 3 months ago

Dang, I didn't wanted to update to the latest JavaFX because when I did I saw some bugs there showing up in the FlowStorm UI. I'm currently using mvn 3.8.7. Will take a look!

Thanks for the info Daniel!

jpmonettas commented 3 months ago

Hmm I was trying and openjfx 23 requires jdk >= 21, which will leave a bunch of FlowStorm users out. FlowStorm currently supports jdk >= 17. The reason it doesn't support jdk 11 is also because of JavaFX. I'm I missing something or libraries like JavaFX should be targeting only the latest jdks?

danielsz commented 3 months ago

Yeah... It's a tough call... I'm in the same predicament as you... Meyvn supports FlowStorm and Morse, but I had to disable that support because of the current issue. Temporarily, at least. JavaFX 22 was apparently compatible with JDK 17, but as you said, JavaFX 23 requires JDK21. Meyvn is compatible with JDK11, so I'm in no mood either to make it so restrictive.