flowable / flowable-engine

A compact and highly efficient workflow and Business Process Management (BPM) platform for developers, system admins and business users.
https://www.flowable.org
Apache License 2.0
8.01k stars 2.63k forks source link

Support UUID value type in flowable-rest API (#3856) #3857

Closed pvojtechovsky closed 3 months ago

pvojtechovsky commented 9 months ago

Fixes #3856

Check List:

tijsrademakers commented 7 months ago

Thanks for the PR, can you also add this variable converter to the cmmn and dmn engine REST APIs?

pvojtechovsky commented 7 months ago

can you also add this variable converter to the cmmn and dmn engine REST APIs?

Makes sense, good idea. I just did it now.

edee111 commented 6 months ago

@tijsrademakers Is there anything blocking this PR? Any idea when will it be accepted?

filiphr commented 6 months ago

@edee111, it would be good if there were some tests for it as well

tomsvet commented 6 months ago

@edee111, it would be good if there were some tests for it as well

@filiphr I added some tests for it.

jkremlacek commented 5 months ago

@tijsrademakers @filiphr Is there anything else that needs to be added to this PR in order to be accepted?

pvojtechovsky commented 4 months ago

Hi @filiphr , what is the problem with this PR please?

tomsvet commented 3 months ago

@tijsrademakers @filiphr Hello, when could this MR be merged, please?

pvojtechovsky commented 3 months ago

It is nearly 6 months since I spent my time to bring feature to the flowable project.

It sounds to me like you are not interested in new features or may be this project is ill? Because having no response from maintainers for nearly 3 months doesn't sound healthy for me.

My trust into flowable project is decreasing. Is flowable project dying? Should I start to search for something more reliable? Could you please give me some inside, so I can understand what is happing here?

Thank you, I hope all is good with you and this PR was just lost. Right?

filiphr commented 3 months ago

@pvojtechovsky the Flowable project is not dying.

The reason why this has not been merged yet is because we need to adjust all the not needed formatting changes that have been done as part of this PR.

e.g. there are * imports being used and we do not use in the project, there are also obsolete whitespace changes.

All of that means that we need to spend more work in integrating the PR and thus it takes a bit longer time. I was actually planning to do that this week (even before you wrote)