search

flowable / flowable-engine

A compact and highly efficient workflow and Business Process Management (BPM) platform for developers, system admins and business users.
https://www.flowable.org
Apache License 2.0
7.99k stars 2.62k forks source link

fix a signal creation bug #3973

Open robert-gurol-ebcont opened 1 month ago

robert-gurol-ebcont commented 1 month ago

Reopening https://github.com/flowable/flowable-engine/pull/3920

@tijsrademakers I specifically asked for pointers in that pull request about where to add a unit test for this - I don't see through the big overall structure of the repository. I want to add unit tests, but I need your help to tell me what I can build on.

EDIT: The code was recently changed here, without any changes to unit tests - I really would have liked to know where to look for those 024ba645a18f2636d0867ac55fdf78f96b28fe80

tijsrademakers commented 1 month ago

Hi, I think a good place to look for is here https://github.com/flowable/flowable-engine/tree/main/modules/flowable-engine/src/test/java/org/flowable/engine/test/bpmn/event/signal. You can add it to the existing SignalEventTest unit test for example. Let me know if you need more info.

robert-gurol-ebcont commented 1 month ago

Thank you! I'll have a look :heart:

PS: The existing tests still run with my change applied :see_no_evil:

tijsrademakers commented 1 month ago

That's good that this test still runs. But it would be great if there could be a test added that's failing without your fix if possible.