search

flowable / flowable-engine

A compact and highly efficient workflow and Business Process Management (BPM) platform for developers, system admins and business users.
https://www.flowable.org
Apache License 2.0
8.01k stars 2.63k forks source link

Flowable Modeler not displaying ID’s of newly created elements #826

Open stijndepestel opened 6 years ago

stijndepestel commented 6 years ago

Hi all,

I've posted to the forum a few days ago, but since there hasn't been a response, I've decided to post it here as well. Original post: https://forum.flowable.org/t/flowable-modeler-not-displaying-ids-of-newly-created-elements/

Basically, I've noticed that newly created elements in the modeler do not show their generated ID in the properties field. I've traced this issue back to at least version 6.0.0.

I've investigated this a bit, and I've noticed that there are two properties concerning the id: the resourceId and the overrideId. The resourceId is correctly generated and stored in the model and is probably the one used in the engine as well. However, the generated id gets never assigned to the overrideId and is thus never displayed in the properties panel (it is the overrideId that gets shown as the id and not the resourceId). Any process that was designed pre-flowable does contain the generated id as the overrideId and is thus displayed properly in the properties panel.

I am willing to provide a PR to fix this, however, I am not sure of what the intended behaviour of these properties are and hence have no idea what to file in the PR.

I'm hoping one of you could clarify how these properties should behave and how this can maybe be fixed.

Kind regards,

Stijn

mlippens commented 6 years ago

This still happens in the last release of flowable, and it still occurs. Can anyone elaborate on the questions of @stijndepestel ? We would still like to fix the issue, but without knowing the details it might be hard to fix it without introducing new bugs.

maudrid commented 6 years ago

+1 We are having some inconsistent behavior with the resourceId/ overrideId. I would like to know what the purpose of this is. Seems like when I create a new process, resource id is set, later after making modifications or publishing, the old resource id is moved to the overrideId and a new resource id is present. The inconsistency is between the json document of the and the generated bpmnModel created by convertToBpmnModel() When I query the processes.get(0).getFlowElements(i).getId(), it turns out that it is returning the override id.