flowaicom / flow-judge

Code for evaluating with Flow-Judge-v0.1 - an open-source, lightweight (3.8B) language model optimized for LLM system evaluations. Crafted for accuracy, speed, and customization.
Apache License 2.0
53 stars 8 forks source link

Feat/haystack integration #9

Closed bergr7 closed 1 month ago

bergr7 commented 1 month ago

Summary Create haystack integration and new tutorial.

Description

This has been tested locally.

There are no automated tests for integrations yet. Waiting for unit tests revamp.

sariola commented 1 month ago

note to add dependency

image

bergr7 commented 1 month ago

note to add dependency

image

It's in a comment at the top of the notebook. Same as in llama index tutorial.

Do you think we need to add it as a dependency to our pyproject.toml?

sariola commented 1 month ago

note to add dependency image

It's in a comment at the top of the notebook. Same as in llama index tutorial.

Do you think we need to add it as a dependency to our pyproject.toml?

I understand.

How about something of this sort? There are always people who don't read like me.

try:
    from haystack import Document
except ImportError:
    print("Haystack is not installed. ")
    print("Please install it according to the 'Additional Requirements' section above.")
    print("\nAfter installation, restart the kernel and run this cell again.")
    raise SystemExit("Stopping execution due to missing Haystack dependency.")
bergr7 commented 1 month ago

note to add dependency image

It's in a comment at the top of the notebook. Same as in llama index tutorial. Do you think we need to add it as a dependency to our pyproject.toml?

I understand.

How about something of this sort? There are always people who don't read like me.

try:
    from haystack import Document
except ImportError:
    print("Haystack is not installed. ")
    print("Please install it according to the 'Additional Requirements' section above.")
    print("\nAfter installation, restart the kernel and run this cell again.")
    raise SystemExit("Stopping execution due to missing Haystack dependency.")

Added suggestion to llama index and haystack tutorials.

sariola commented 1 month ago

Could add that for a finegrained token need to enable these permission scopes image

sariola commented 1 month ago

The batch eval at the end takes about 2 min per run and uses multi-gpu ok via accelerate. Works :ok: image

sariola commented 1 month ago

I consider it E2E tested from my side!

sariola commented 1 month ago

Does it handle parsing errors for you guys?

image

bergr7 commented 1 month ago

The batch eval at the end takes about 2 min per run and uses multi-gpu ok via accelerate. Works 🆗 image

yes it's quite slow... hopefully we can replace with vllm engine soon or cpu.

bergr7 commented 1 month ago

Does it handle parsing errors for you guys?

image

flow-judge does, haystack doesn't. I don't know if there is a way of working around them. Need to check.

bergr7 commented 1 month ago

Does it handle parsing errors for you guys?

image

I guess this is due to the phi-3 issue? have you checked the output?

sariola commented 1 month ago

Does it handle parsing errors for you guys? image

I guess this is due to the phi-3 issue? have you checked the output?

Yeah, I'm on it. I think the onnxruntime engine just takes up all the VRAM and cranks even on the sync exec. I'm making some changes to the current test implementation of batch_generate of the class. Should be done in a bit.