Expose HTTP Handler to allow config / swappability

[mbryzek]

provides implementation for https://github.com/flowcommerce/ruby-sdk/pull/16

[paololim]

Will any change to this be overwritten the next time we generate a new apidoc client?

[mbryzek]

not until we merge https://github.com/mbryzek/apidoc-generator/pull/174

[paololim]

lgtm

[Tonkpils]

This looks good to me as it gives us complete control over the http library to use as we're not tied down to use the default http handler.

[jimm]

LGTM

[Tonkpils]

Does the usage of the Flow client always return the same instance (e.g singleton)? If that's the case, this may not be threadsafe when changing options on the exposed client on DefaultHttpHandler.

[mbryzek]

threadsafe: You're right - The current implementation creates a new instance - will go back to that

[mbryzek]

fyi: replaced puts with logger

[mbryzek]

Refactored a bit to separate instantiation of the client itself from the logic. Removes the need to remember past settings - and isolates custom handlers from any internal config (like service base url)

[paololim]

lgtm

[mbryzek]

@jimm @Tonkpils we've updated based on your feedback - we have published new gem version: 0.2.0 - if you get a change, would love to know if this works for you guys (and if not we can iterate from here).

thanks for the suggestion and feedback!

[jimm]

@mbryzek thank you, we'll check as soon as we're able