search

flowcore-io / luttaka-open

The open source event experience app powered by the Flowcore Data Management Platform
https://luttaka.com
MIT License
12 stars 11 forks source link

Adjust the dark-mode colours to match the spec. #134

Closed suuunly closed 5 months ago

suuunly commented 5 months ago

Is your improvement request related to a specific problem in the code or project structure? Please describe. 👨‍💻 Currently, the background colours of the app is pitch black in dark mode. This does not match the spec

Describe the improvement or refactor you would like 🎯 The background colours in dark mode should match the spec:

Dark: 48556E Darker: 384155 Darkest: 282F3C

image_720

Explain why this improvement or refactor is beneficial 🎖️ This keeps the product up to code with the expected spec.

Additional context or comments Consider using the tailwind.config and the global.css to adjust the colours. do not set the colours directly in the code. This should be defined in the theme - to make sure it reaches the entire project

Elaa257 commented 5 months ago

Hi, I think I can help with this problem and would like to work on this as my first issue :)

suuunly commented 5 months ago

@Elaa257 Of course, you are welcome to take on the task :) I have assigned it to you 😄

Elaa257 commented 5 months ago

@suuunly I'm not sure if you can help me with this, but I am struggling setting up the project. The instructions in the ReadMe are not clear to me. Could you please describe in more detail what I need to do with the .yaml-files? I have already tried different ways, but it is still not working correctly.

suuunly commented 5 months ago

@Elaa257, you need to duplicate the flowcore.local.example.yaml file, and rename it flowcore.local.yaml. Then you need to replace the <some tenant> part, with the organisation name you have on Flowcore 😄

The readme is a little convoluted atm, so I've created several tasks that try to remedy that 😄

hediinn commented 5 months ago

hi, plzz assign me

suuunly commented 5 months ago

@hediinn. You have been assigned the task as well :)

suuunly commented 5 months ago

Here is a dark mode example of both desktop and mobile: image

Elaa257 commented 5 months ago

@suuunly thank you, I am going to try it again with this information :)

suuunly commented 5 months ago

@Elaa257, @hediinn solved this issue yesterday. Awaiting a PR approval. So it would probably be better to take another, similar task instead 😁

Elaa257 commented 5 months ago

@suuunly okay, I will have a look :)