flowdock / hubot-flowdock

Flowdock adapter for Hubot chat bot
94 stars 60 forks source link

Support "undo" #67

Closed erkattak closed 9 years ago

erkattak commented 10 years ago

I'm not sure this is possible, but it'd be great to tell hubot to delete it's last message.

Mumakil commented 10 years ago

This might be possible, but I'd like to figure out first what's the motivation here and how would you expect this to work? Hubot might be talking in multiple flows and private conversations, so this would need to be on a per-flow basis. I'm thinking something like commenting the same thread and then hubot would delete the previous message.

Also, I'm not sure this is needs to be done in the flowdock adapter, since a script with a proper command sounds like a better fit.

erkattak commented 10 years ago

Commenting in the same thread is how I imagined it working as well. The motivation here is that sometimes when using external services to search or display some content, it might return inappropriate results and we'd like to be able to censor hubot.

Mumakil commented 10 years ago

Thanks for the clarification! I feel this would better fit a userscript since it's an explicit command and does not fall exactly into the domain of a connection adapter (nor does the hubot adapter have a common interface for this). That said, a script would still need to take into account which connection adapter is in use.

I'm closing this ticket since I don't think we'll be implementing this in hubot-flowdock for now, but if you want help with writing a userscript I'm happy to help!

brentc commented 10 years ago

I actually implemented this as a user script for our needs a while back. Because it's flowdock specific, I haven't released it anywhere, but here it is:

https://gist.github.com/brentc/63ce932e6c0dd8ea3b7a

erkattak commented 9 years ago

Thanks @brentc that's exactly what I was thinking. This is similar

https://github.com/cdoughty77/hubot-flowdock-delete-message

Mumakil commented 9 years ago

Great! I'll add these to the readme so maybe they are found more easily if anyone else needs similar functionality!