search

flowdock / oulu

Flowdock IRC Gateway
MIT License
76 stars 16 forks source link

make PASS command work for authentication #34

Closed aerickson closed 11 years ago

aerickson commented 11 years ago

The previous work on this (https://github.com/flowdock/oulu/pull/31) didn't result in a working implementation. The attached code works for me when testing with LimeChat (a fairly generic IRC client for OS X) and follows the RFC for IRC on the PASS command (http://www.irchelp.org/irchelp/rfc/chapter4.html#c4_1_1). The command sequence the client issued was:

03:05:39 app.1 | PASS **** 03:05:39 app.1 | NICK a 03:05:39 app.1 | USER user@.com 0 * c

The comments in pull request 31 seem to be attempting to auth on /connect (which seems pretty different).

Comments about the changes:

pass_command.rb:

user_command.rb

mutru commented 11 years ago

Thank you @aerickson for the pull request! Indeed, seems that IRC clients have compatibility issues with the pass command - they can't seem to decide if they should be sending multi-word passwords in one argument or in several arguments.

We had just fixed this in another pull request, and refactored a bunch of other stuff as well, so I'm not merging this PR. Thanks for the contribution in any case.