search

flowdock / oulu

Flowdock IRC Gateway
MIT License
76 stars 16 forks source link

Configurable option for NOT sending emojis #49

Closed lukaszkorecki closed 10 years ago

lukaszkorecki commented 10 years ago

Weechat on Linux can't show emojis (it's kinda Linux issue) but I can see other scenarios where sending :raw_emoji_string: instead would be beneficial.

lautis commented 10 years ago

This is an issue on all clients that use fixed-width typefaces. Even if emojis are supported, they are doublewidth and mess up the fixed width rendering. Gemoji gem could be used to translate unicode emoji code points to :raw_emoji_string. We're already using that in our API to do the translation from :raw_emoji_string:.

lukaszkorecki commented 10 years ago

Right - I'm happy to work on a pull request and add this as an option.

I just would like to know if it's something that would be merged and released if you guys are happy with it.

lautis commented 10 years ago

We'd glad to merge a PR.. Having emoji as :raw_emoji_string: should be the default as most IRC clients can't render colourful emoji. IMHO, making this configurable isn't even necessary.

lukaszkorecki commented 10 years ago

Great, I will see what I can do then, I used to have some code which did this in a crude way.

On Thu, Jan 30, 2014 at 12:03 PM, Ville Lautanala notifications@github.comwrote:

We'd glad to merge a PR.. Having emoji as :raw_emoji_string: should be the default as most IRC clients can't render colourful emoji. IMHO, making this configurable isn't even necessary.

— Reply to this email directly or view it on GitHubhttps://github.com/flowdock/oulu/issues/49#issuecomment-33681727 .

Łukasz

lautis commented 10 years ago

Btw, the Gemoji unicode mapping functionality only works when Gemoji installed via github. See https://github.com/github/gemoji#unicode-mapping

lukaszkorecki commented 10 years ago

Closed in https://github.com/flowdock/oulu/pull/53