Send emoji as text - Githubissues

flowdock / oulu

Flowdock IRC Gateway

MIT License

76 stars 16 forks source link

Closed lukaszkorecki closed 10 years ago

lukaszkorecki commented 10 years ago

This is partially a patch and to a lesser extent a proposal because I discovered couple of things when working on this change.

some tests were passing, but what it seems for the wrong reasons (see inline notes)
I didn't run integration tests :-/
my editor would clean up the whitespace, therefore some extra diff noise is introduced
I've tested changes as extensively as I could using my real flowdock account etc and everything worked as expected

before (using weechat 4.0) before

after after

leocassarani commented 10 years ago

@flowdock Any progress on this? Would be great to have it merged in.

lautis commented 10 years ago

Thanks! Sorry about the delay. It may take few additional days for this to get pushed into production.

lukaszkorecki commented 10 years ago

@lautis No worries - can't wait to see it working on production