flowdriveai / flowpilot

flow-pilot is an openpilot based driver assistance system that runs on linux, windows and android powered machines.
GNU General Public License v3.0
1.67k stars 240 forks source link

Tried in Dashcam Mode, the banner takes half of the screen. Is this a bug or by design? #43

Closed gitercn closed 8 months ago

gitercn commented 1 year ago

Describe the bug My car is not in the supported list and I don't have the hardware to connect to a car, but I wanted to try out this in Dashcam Mode. I followed the installation guide and successfully installed and launched the app. However, the Dashcam Mode green banner takes half of the screen, makes the lane lines hard to see. Is this a bug or by design?

Screenshot_ai flow android

To Reproduce

  1. Followed the installation guide to install the premium version.
  2. Uncommitted the line #export FINGERPRINT="HONDA CIVIC 2016" in launch_flowpilot.sh to hardcoding figureprinting since my car is not supported.
  3. Set USE_SNPE="1" in launch_flowpilot.sh to enable SNPE.
  4. Launched flowpilot and opened python scripts/dummy_publishers.py.

Expected behavior Make the Dashcam Mode banner smaller in able to view the lane predictions. Also, the speed shows on the screen kept at 72 kmph. I guess the speed is from the dummy_publishers.py? Is it possible to get real speed from phone's GPS?

Platform Details

Android :

MankaranSingh commented 1 year ago

its expected behavior actually. you can remove the dascam event in controlsd.py to remove this banner.

Expro commented 1 year ago

Yeah, same issue on PC with additional info on "car unrecognized". It would be great to have and X or toggle to disable those messages as they make it completely unusable.

Expro commented 1 year ago

Also, removal of "dashcam event" and "unrecognized car" event spawns "Flowpilot not available" message, which also takes half of screen...

You need to edit some .java file to hide those as well.

mohit-deepgrid commented 8 months ago

Do we have to reinstall after making changes in the .java files for the changes to reflect?

MankaranSingh commented 8 months ago

Do we have to reinstall after making changes in the .java files for the changes to reflect?

you will need to build the android apk again. Setup the project on desktop (check wiki) then rebuuild the apk as you would normally do for an android project.