search

flowhella / get-flash-videos

Automatically exported from code.google.com/p/get-flash-videos
0 stars 0 forks source link

Patch to use Crypt::Blowfish instead of Crypt::Blowfish_PP #344

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Hi,

Crypt::Blowfish_PP is unmaintained for a while, please consider use 
Crypt::Blowfish in lib/FlashVideo/Site/Channel4.pm.

Attached patch to use it.

Original issue reported on code.google.com by darkju...@gmail.com on 10 Jan 2012 at 3:51

Attachments:

GoogleCodeExporter commented 8 years ago 
Thanks for the patch but I'm not convinced there's much value in it. 
Crypt::Blowfish_PP might not have had any changes made to a while, but neither 
has the Blowfish algorithm so I don't see the problem. Using the pure-Perl 
version also allows us to bundle the module with the combined version 
get-flash-videos, which we can't do with Crypt::Blowfish as it has XS too. The 
pure-Perl version is also much easier for people on Windows and other operating 
systems where compilers are not easily available.

If you feel strongly that you want the code to use Crypt::Blowfish, please make 
it check for both. Since the modules have an identical API, once you've figured 
out which module is installed, you can just create an instance of that, and the 
decrypting code should remain the same.

Original comment by zakflash...@gmail.com on 12 Jan 2012 at 6:18

GoogleCodeExporter commented 8 years ago 
Closing, lack of response.

Original comment by zakflash...@gmail.com on 9 Apr 2012 at 3:38