search

flowhella / get-flash-videos

Automatically exported from code.google.com/p/get-flash-videos
0 stars 0 forks source link

tou.tv... tou.pm need a little modification #359

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
On line 23, needs to set the pid string in uppercase.

  if ($browser->content =~ /,"PID":"(\w+)"/) {

Original issue reported on code.google.com by bobin...@gmail.com on 11 Feb 2012 at 3:37

GoogleCodeExporter commented 8 years ago 
Checking the line before your suggested change was this 

if ($browser->content =~ /,"pid":"(\w+)"/i) {

which is case insensitive match. That will match uppercase PID, it will also 
work should the site use some other combination of case PiD for example. As far 
as I can see this neither solves a problem or improves anything and may give 
rise to more download failures for the site.

A trail download from this site was working for me, without your change. What's 
the reason for your change was something broken then what...

Original comment by njtaylor...@gmail.com on 11 Feb 2012 at 6:16

GoogleCodeExporter commented 8 years ago 
Hello

Are you sure about the case insensitive match?

Downloading files from tou.tv work for me *since* i set the string "PID" 
uppercase

Original comment by bobin...@gmail.com on 11 Feb 2012 at 6:41

GoogleCodeExporter commented 8 years ago 
oh... i see.. on my "original" Tou.tv file.. the match is not case insensitive.

So your solution is better than mine... 

Thank's

Original comment by bobin...@gmail.com on 11 Feb 2012 at 6:49

GoogleCodeExporter commented 8 years ago 
I see your probably using an out of date version probably 1.24 downloaded from 
this site or based on the downloads. These changes aren't mine, they come from 
an update made 5 Dec 2010, for a previous issue 191, you only found one of the 
7 changes made. You either need to update from the git repository here or you 
could use mine, which has newer download files...

https://github.com/njtaylor/get-flash-videos/downloads

I made these downloads not to long ago, missing one or two updates now. Not 
sufficient to warrant creating a new set of downloads for an OpenBSD 
ports/package update. Not so woefully neglected as here, where a new version 
release with the provision of new downloads here would stop some of the 
duplication of the same old issues.

Original comment by njtaylor...@gmail.com on 11 Feb 2012 at 8:47

GoogleCodeExporter commented 8 years ago 
Fixed, please use latest git code.

Original comment by zakflash...@gmail.com on 20 Jun 2012 at 8:28