flowhorn / schulplaner

In this repository we collaborate to build the perfect school planner. And you can help us.
GNU General Public License v3.0
31 stars 10 forks source link

"Go Back" button on the login page #155

Closed Th3Ph4nt0m closed 3 years ago

Th3Ph4nt0m commented 3 years ago

General Troubleshooting

Feature Request

If the login failed, there is no nice possibility to go back to try again. There should be a "Go Back" button.

JBetts97 commented 3 years ago

Hello @Th3Ph4nt0m,

Thanks for your help on discord earlier today! 👍 Just to clarify with this issue, do you mean to improve the error AlertDialog shown when trying to login with an incorrect user/pass?

Something like from this: image

To this: image

Th3Ph4nt0m commented 3 years ago

I am talking about the screen when the login failed: There is no actual possibility to go back.

JBetts97 commented 3 years ago

Sorry @Th3Ph4nt0m , I would just to clarify this request further:

I can replicate this issue by doing the following from first screen:

  1. Select 'Google' as sign-in method.
  2. Cancel Google authentication (press back on OS button)

So now you are at this screen, you would like a faster way to re-try with Google? So the expected functionality is to press 'back' instead of pressing tap to 'tap to retry' then 'google'? Is this correct?

Th3Ph4nt0m commented 3 years ago

The Tap to retry wasn't working for me. Anyway, this text does not look like "Hey click me" so users will be confused.

JBetts97 commented 3 years ago

Thanks for the clarification. 👍 I will try to make the "sign in failed tap to retry" button look a more like a UI button rather than a message. I will also correct the spelling of "Select methode" to "Select method".

Th3Ph4nt0m commented 3 years ago

I already "fixed" the spelling in #154 so you don't need to, this could evoke merge conflicts. Thank you!

JBetts97 commented 3 years ago

No problem! I will just work on making it look more like a UI button.