search

flowhub / guv

Autoscaling for Heroku/AMQP
https://guvscale.com
MIT License
25 stars 6 forks source link

Fix config issue when multiple apps have roles with same name #221

Closed timlesallen closed 6 years ago

timlesallen commented 6 years ago

Fixes a conceptual error whereby it's assumed that process names are unique on heroku. This can result in the wrong worker counts being used for the wrong config entries... Note, includes https://github.com/flowhub/guv/pull/220...

jonnor commented 6 years ago

I see now there are two failing tests on Travis, these would need to be addressed. I am checking if they are due to unrelated changes (master build last ran on a change some months ago).

jonnor commented 6 years ago

The tests are passing on Travis CI. Can you look into the failures here?

jonnor commented 6 years ago

@timlesallen I rebased this to remove the scaling change, and it is now in master. Thanks!

The test fails on Travis CI was first because the envvars required. I made the failure messages clearer about this. Since we use mocks anyway, would be nice to. Fixed issue here: https://github.com/flowhub/guv/issues/222

However there was some minor issues causing the added test to faile, see https://github.com/flowhub/guv/commit/387cd73873362c026d8e159ca793858793e519d3