Restore PHP 5.3 compatibility

flowjs / flow-php-server

flow.js php server library, validates uploaded chunks and safely merges all chunks to a single file

http://flowjs.github.io/ng-flow/

MIT License

245 stars 42 forks source link

Restore PHP 5.3 compatibility #27

Closed giovyloca closed 8 years ago

giovyloca commented 8 years ago

The package is compatible with PHP 5.3 apart from the array notation. I think it's better to take a conservative approach and keep the backward compatibility.

Redoing this because of scrutinizer failing the first time.

AidasK commented 8 years ago

Why are you using 5.3 php? It is officially unsupported.

giovyloca commented 8 years ago

Because I'm not. Client does. Sure, I suggested them to upgrade, but turns out they host different sites for which I can't guarantee. Funny how someone would reinvent shared hosting and dub it "cloud", isn't it? :) Anyway, 5.3 is good enough for them: https://github.com/symfony/symfony/blob/2.8/composer.json#L19 5.3 was the release that got rid of a lot of old cruft, I think it's only good if we can keep the compatibility with it.

AidasK commented 8 years ago

Thanks. Supporting 5.3 shouldn't be a problem, because library is quite stable. Use commit hash for now in composer

giovyloca commented 8 years ago

Thanks! :smiley: