Stop retrying chunks when file paused - Githubissues

flowjs / flow.js

A JavaScript library providing multiple simultaneous, stable, fault-tolerant and resumable/restartable file uploads via the HTML5 File API.

Other

2.96k stars 346 forks source link

Stop retrying chunks when file paused #298

Closed JonUK closed 4 years ago

JonUK commented 4 years ago

This is a fix for an issue I hit where a chunk failed to upload (as device was offline) and then the file was paused. Even though the file was now paused, the chunk uploading was still retried (while device still offline) and once the maxChunkRetries limit hit, the file upload was considered failed, all still while the file was paused.

JonUK commented 4 years ago

I've bumped the patch version via the grunt release step but if this is not desired, can always re-raise without the version number change.

AidasK commented 4 years ago

Yes, you should not change the dist files. Does the tests pass?

JonUK commented 4 years ago

Yes... the unit tests all passed. I will revert the dist and version number changes.

JonUK commented 4 years ago

Done

AidasK commented 4 years ago

Thanks!

JonUK commented 4 years ago

Hi. Will this v2.14.1 be published to npm?

AidasK commented 4 years ago

Published!

JonUK commented 4 years ago

Much appreciated