Sauce reporter error - Githubissues

flowjs / flow.js

A JavaScript library providing multiple simultaneous, stable, fault-tolerant and resumable/restartable file uploads via the HTML5 File API.

Other

2.96k stars 346 forks source link

Sauce reporter error #316

Closed drzraf closed 3 years ago

drzraf commented 3 years ago

In #309 (cfcc849) we updated karma-coverage to v2.
In #314 (a0eafbc1) we updated karma-sauce-launcher from v0 to v4 but v2 introduced a bug keeping --single-run=false from working.

This commit:

moves more of the static Karma configuration from Gruntfile back into karma.conf
adds two SauceLabs browsers flavors
adds a guard when karma:saucelabs is used without defined SauceLabs credentials
disables the saucelabs in the default karma config to restore --single-run=false until https://github.com/karma-runner/karma-sauce-launcher/issues/217 is fixed.

AidasK commented 3 years ago

Looks great, not much to review :))