flowjs / flow.js

A JavaScript library providing multiple simultaneous, stable, fault-tolerant and resumable/restartable file uploads via the HTML5 File API.
Other
2.96k stars 346 forks source link

Reenable SauceLabs CI in v3 #327

Closed drzraf closed 3 years ago

drzraf commented 3 years ago

https://github.com/flowjs/flow.js/issues/322

drzraf commented 3 years ago

First test:

drzraf commented 3 years ago

Second attempt:

Problems:

evilaliv3 commented 3 years ago

@drzaf as for the SAUCE_ACCESS_KEY i can manage to load it on travis or to load it encrypted; Lets finish the patch and i will then take care of this.

As for the issues on the browser versions i suspect that we may be using an outdated version of the webdriver; i'm checking on this right know

Typically when choosing version i like to have the first version on which we offer compatibility (based on the capabilities we use and checking it on caniuse) and then have the latest available stableversion of each browser identified on saucelabs by the keyword stable so that it automatically keep updating)

evilaliv3 commented 3 years ago

@drzraf looking at https://github.com/karma-runner/karma-sauce-launcher#readme i read that in relation to W3C mode you should check the following resource and update the configruation for the browsers

    // For W3C way of setting the capabilities check
    // https://wiki.saucelabs.com/display/DOCS/Platform+Configurator#/
    // And select WebDriver (W3C) Selenium 3/4, Webdriver.io

Please let me know if you need any support on this.

evilaliv3 commented 3 years ago

Key added to travis @drzraf @AidasK

Screenshot_2021-01-07 flowjs flow js - Travis CI

drzraf commented 3 years ago

https://wiki.saucelabs.com/display/DOCS/W3C+Capabilities+Support

Brower W3C version
Chrome 75 and above
Edge All
Firefox 55 and above
Internet Explorer All
Safari 12 and above

I didn't understood how to downgrade the test to JWP. https://github.com/karma-runner/karma-sauce-launcher/blob/master/src/process-config.ts#L60 isW3C() => Boolean(capabilities.browserVersion) (IIRC, settings browserVersion would opt for w3c, setting version to JWP)

drzraf commented 3 years ago

@evilaliv3 : In case you can spot what's wrong with that karma's Sauce configuration.

drzraf commented 3 years ago

I'm still struggling to get SauceLabs to work.

@evilaliv3 : Would you mind giving me an access to SauceLabs? I could then check whether my local tunnels actually go well and attempt to run SauceLabs from localhost. (I actually can do it but lack some information from SauceLabs backend)

Note: Screenshot from 2021-01-23 02-30-58

I'm pretty sure I'm not the one who run these "Unnamed jobs". If that's right, someone else is using publicly available Sauce username/secret-key to test their own app. I tried to removed them from the repository, but seems like Travis variables (if actually defined?) weren't taken into account.

drzraf commented 3 years ago

Dears, it was painful (unsupported versions, saucelabs errors, saucelabs timeout, options object passing format, ...) it finally got it passed but... only with tested on "new" browsers.

I suggest to merge the PR as-is but enable more Saucelabs browsers version in a subsequent PR. I couldn't remove Saucelabs username/keys because it seems Travis is not passing those registered in its configuration (@evilaliv3)

It was sufficiently painful that I still consider TestingBot (#325) a very compelling option.

AidasK commented 3 years ago

@drzraf It does not matter what you choose, just make sure it's working. Don't waste time on Saucelabs if it's so troublesome. Automatic tests on couple of browsers is good for me too

evilaliv3 commented 3 years ago

@drzraf : i'm sorry i just noticed your message.

I tried to access the accont on saucelabs but it seems that it is not connected to my email address anymore.

@AidasK : maybe i already passed it to you? did you received any email ?

AidasK commented 3 years ago

@evilaliv3 No, I can't see any project on Saucelabs