flowjs / flow.js

A JavaScript library providing multiple simultaneous, stable, fault-tolerant and resumable/restartable file uploads via the HTML5 File API.
Other
2.96k stars 346 forks source link

When importing a folder, all files from same folder have same relativePath [v3 only] #341

Closed bertrandg closed 3 years ago

bertrandg commented 3 years ago

I got this bug when importing a folder using function webkitReadDataTransfer() (& readDirectory()).

Here are the details, I drop the following all folder:

image

Then, like you see in screenshot, all files inside a folder got same fullPath property:

image image image image

I found the error comes from there:

https://github.com/flowjs/flow.js/blob/218b2bf76d840a4eb0013e3db2a0ff764d93eab7/src/Flow.js#L257

That could be easily fix, I will make a merge request later this week if you are ok with it.

AidasK commented 3 years ago

yes, feel free to submit it. Have you checked v2? Does it handle it ok?

bertrandg commented 3 years ago

Fix merged for v3.

And v2 handles it ok: image

AidasK commented 3 years ago

That's great! Thanks for double checking it