search

flowjs / flow.js

A JavaScript library providing multiple simultaneous, stable, fault-tolerant and resumable/restartable file uploads via the HTML5 File API.
Other
2.96k stars 346 forks source link

Convert codebase to asynchronous code (reroll v2) #363

Closed drzraf closed 2 years ago

drzraf commented 2 years ago

Reroll and continuation of #354

AidasK commented 2 years ago

Looks great. Code is much more simpler and more readable

ilessiivi commented 2 years ago

Thanks for the effort!

Two quick notes:

  1. The .include() in Eventizer.js needs to be .includes()
  2. A couple of the tests fail, I'll take a look if it's just some missing awaits or something more

I'll close #354, let's continue here.

drzraf commented 2 years ago

I'll try to remove asyncReadFileFn (but this impacts preprocess behavior too) in this very PR, but either way I think it's now mergeable (so we can work on other PR related to generateUniqueIdentifier, or other enhancements you had in mind @ilessiivi ...) Do you confirm?

ilessiivi commented 2 years ago

It accomplishes the original goals and it passes all the tests - I would be happy to have this PR merged! Indeed there are still a couple of little things we should do in smaller individual PRs, but I think the project is soon ready for a v3 pre-release (in regards to #353).

AidasK commented 2 years ago
image

@drzraf Do you know why I am getting these emails? What is being deployed with this approve?

AidasK commented 2 years ago

Sadly this email does not have a link to a branch or MR which requires this review

drzraf commented 2 years ago

The CI runs need to be approved because:

That's why the CI process allows for a maintainer to have a look to the diff (regarding CI safety of token/secrets) and, if deemed safe, accept it (to run the the open-env which contains the secrets)