Use reviewer approval to trigger testing

flowjs / flow.js

A JavaScript library providing multiple simultaneous, stable, fault-tolerant and resumable/restartable file uploads via the HTML5 File API.

Other

2.96k stars 346 forks source link

Closed drzraf closed 2 years ago

drzraf commented 2 years ago

Still looking for an ideal & safe PR testing/deployment workflow.

AidasK commented 2 years ago

I think this implementation has a bug because it checks if "source-changed". So this flow won't work:

files changed
tests fail
readme.md changed, tests still fail, but tests pass without running because no files has changed

drzraf commented 2 years ago

Yes. I'm trying get my head around tj-actions/changed-files in combination with pull_request_target Let's discuss at #366