search

flowjs / flow.js

A JavaScript library providing multiple simultaneous, stable, fault-tolerant and resumable/restartable file uploads via the HTML5 File API.
Other
2.96k stars 346 forks source link

Added 'loadend' event listener #386

Open olavivaino opened 1 year ago

olavivaino commented 1 year ago

Added 'loadend' event listener to xhr. Why is this needed? Appears that in Firefox ver 109.0.1 xhr does not always fire event 'load'. But does fire 'loadend'. Problem was discovered while debugging old Angular 1 application. It is not reproducible in plain playground environment.

AidasK commented 1 year ago

Probably because we are not handling other events such as abort. Anyways, we can not do that as uploadNextChunk will be called twice (after load and loadend) and it will be uploading 2x more chunks than it should after each chunk

aayusharyan commented 1 year ago

So, if this is not an issue in Vanilla Playground, then that means some issue with Angular integration of this package. 🤔

olavivaino commented 1 year ago

Yes, uploadNextChunk will be called twice (unless FF is used), what kind of problems can this cause? I tested single and multiple file uploads and didn't notice anything obviously wrong. Perhaps better fix would be to trigger only "loadend" and not "load".