search

flowjs / fusty-flow.js

Flow.js html5 file upload support for older browsers using iframe
MIT License
48 stars 22 forks source link

Library is not compatible with module loaders. #12

Open Undergrounder opened 8 years ago

Undergrounder commented 8 years ago

The library is using some globals (window.Flow and window.FustyFlow) instead of requiring them and the FustyFlow class is never imported when using npm require.

This makes using it with webpack and other module bundlers very tricky.

evilaliv3 commented 8 years ago

@Undergrounder do you have any suggestion or you have a possible pull request in mind? :)

Undergrounder commented 8 years ago

I could prepare a pull request with the tools I'm confortable (webpack) if you agree with this.

It would be then compatible with the browser, the amd and CommonJS specifications.

AidasK commented 8 years ago

You are good to go, If you can make it without breaking changes

Undergrounder commented 8 years ago

Closed in #15

evilaliv3 commented 8 years ago

thanks @Undergrounder ! so well done!

i've left you some comments for some corrections i think we would need before merging the patch. would you please evaluate to refine it?