search

flowjs / ng-flow

Flow.js html5 file upload extension on angular.js framework
http://flowjs.github.io/ng-flow/
MIT License
1.38k stars 303 forks source link

support umd #333

Open graingert opened 7 years ago

AidasK commented 7 years ago

@evilaliv3 Can you review this? I haven't used yarn or webpack so I can't test this. But as long as all tests are passing, it is good for me.

I think this will be a breaking change for all of our users. We can release it under a major version.

graingert commented 7 years ago

@AidasK ok I'll change it so it's not breaking

AidasK commented 7 years ago

You have also removed ng-flow.js from dist folder, this is bc.

I am not against of breaking things. There is nothing wrong in releasing a major version if it is needed.

graingert commented 7 years ago

You have also removed ng-flow.js from dist folder, this is bc.

oh woops, that's an error.