flowkey / UIKit-cross-platform

Cross-platform Swift implementation of UIKit, mostly for Android
MIT License
600 stars 40 forks source link

Rename Window to GLRenderer #174

Closed ephemer closed 6 years ago

ephemer commented 6 years ago

Motivation

Window is a confusing name for an internal type when we already have the public UIWindow. I'm refactoring this code with the aim of implementing UIViewController in the next step (upcoming PR).

Testing Details

Builds and tests run

Please check if the PR fulfills these requirements

rikner commented 6 years ago

@ephemer Größe oder Scale scheint irgendwie noch nicht hinzuhauen?

bildschirmfoto 2018-04-18 um 18 08 04

edit: im view controller PR funktioniert es schon wieder, weil wir dort für UIScreen.main

let size = SDL.glRenderer?.size ?? CGSize(width: 1024, height: 768)

return UIScreen(
    bounds: CGRect(origin: .zero, size: size),
    scale: SDL.glRenderer?.scale ?? 2.0 
)

verwenden. Sollten wir hier auch noch machen, damit der master sauber bleibt.

ephemer commented 6 years ago

@rikner it's fixed. Well spotted with the bug- thanks for reviewing!

bildschirmfoto 2018-04-19 um 16 38 37