Added horizontal scroll indicator and improved indicators' behaviour when deceleration animation is on

janek commented 6 years ago

Fixes # https://github.com/flowkey/UIKit-SDL/issues/195 + improves deceleration behaviour

Type of change: feature + bug fix

Motivation

The horizontal indicator had not been implemented and was therefore not visible in ScrollableSheet view. When it was added, it was also not animating properly when the sheet deceleration animation was on.

Todos

[x] Implemented horizontal indicator (based on the code for vertical)
[x] Improved behaviour of indicators under animation
[x] Corrected the positioning of the indicators to take anchor point into account
[x] Add tests
[ ] Implement bouncing (low priority at the moment)

Current behavior

Indicator in ScrollableSheet not visible.

Expected behavior

Indicator in ScrollableSheet visible and behaving comparably to iOS.

Please check if the PR fulfills these requirements

[ ] Self-review: I am confident this is the simplest and clearest way to achieve the expected behaviour
[x] There are no dependencies on other PRs or I have linked dependencies through Zenhub
[x] The commit messages are clean and understandable
[x] Tests for the changes have been added (for bug fixes / features)
[x] Code runs on all relevant platforms (if major change: screenshots attached)

ephemer commented 6 years ago

Whoops, started in German and finished in English. I'm a bit tired today. For future reference, let's keep communication in this repo in English :)

janek commented 6 years ago

@ephemer I added a few tests and test stubs for UIScrollView and implemented 2 small fixes for bugs I discovered while testing. Some comments and some code from Tests should be removed before merging this, but I'm leaving them in for now (as they should make it simpler for us to go over the code)

janek commented 6 years ago

@ephemer implemented all of the changes that you suggested in the review. seems like I didn't break anything in the process. still working on covering it better with tests and adding new (small) features.

ephemer commented 6 years ago

Hi @janekszynal can you have a look into the test failures here? It'd be cool to merge this and continue on the tests in another PR.

flowkey / UIKit-cross-platform