Closed janek closed 6 years ago
Whoops, started in German and finished in English. I'm a bit tired today. For future reference, let's keep communication in this repo in English :)
@ephemer I added a few tests and test stubs for UIScrollView and implemented 2 small fixes for bugs I discovered while testing. Some comments and some code from Tests should be removed before merging this, but I'm leaving them in for now (as they should make it simpler for us to go over the code)
@ephemer implemented all of the changes that you suggested in the review. seems like I didn't break anything in the process. still working on covering it better with tests and adding new (small) features.
Hi @janekszynal can you have a look into the test failures here? It'd be cool to merge this and continue on the tests in another PR.
Fixes # https://github.com/flowkey/UIKit-SDL/issues/195 + improves deceleration behaviour
Type of change: feature + bug fix
Motivation
The horizontal indicator had not been implemented and was therefore not visible in ScrollableSheet view. When it was added, it was also not animating properly when the sheet deceleration animation was on.
Todos
Current behavior
Indicator in ScrollableSheet not visible.
Expected behavior
Indicator in ScrollableSheet visible and behaving comparably to iOS.
Please check if the PR fulfills these requirements