flowkey / UIKit-cross-platform

Cross-platform Swift implementation of UIKit, mostly for Android
MIT License
597 stars 40 forks source link

accepted all of Xcode's 'Update to recommended settings' #222

Closed janek closed 6 years ago

janek commented 6 years ago

(PARTIALLY) Fixes # https://github.com/flowkey/UIKit-SDL/issues/221

Type of change: project cleanup

Motivation

We have 4 warnings and they're very easy to fix. Especially since this repo will eventually get published, I think it's worth it to get rid of them.

Info

Xcode 9.4 shows 4 warnings, each saying "Update to recommended settings": for UIKit, SDL-gpu, SDL-ttf and SDL Project.

In most of those, it's extremely easy to fix - Xcode just wants to know if we want to enable some new checks that were added in v9.3:

CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES; CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;

I see no downside to accepting (it's just about allowing Xcode to warn us about some things). But they can also easily be ignored, and the warnings still go away.

This branch accepts the checks for UIKit and updates the automatic value tells Xcode 9.4 it already asked. (Newer versions of Xcode might ask later ask for newer things).

The only case that's slightly more complicated is SDL Project. For that one, Xcode suggests more updates and it's hard for me to say which ones should be accepted. For myself, I just didn't accept any of them, but for the master branch it would be cool if @ephemer could take a look.

Note that the changes in this branch will only resolve the warnings for UIKit. The other three are submodules and they need to be updated in their individual repos. (Hence the '(PARTIALLY) Fixes #221 ')

rikner commented 6 years ago

👍

janek commented 6 years ago

I'll keep this open for now, since it contains info related to solving the issues in other repos.