ensure nativeOnVideoEnded is called once - Githubissues

flowkey / UIKit-cross-platform

Cross-platform Swift implementation of UIKit, mostly for Android

MIT License

597 stars 40 forks source link

ensure nativeOnVideoEnded is called once #231

Closed michaelknoch closed 6 years ago

michaelknoch commented 6 years ago

Type of change: bugfix

Current behavior

It can happen that exoplayer sets Player.STATE_ENDED multiple times

Expected behavior

We need a reliable callback that gets called when the video has ended.

Please check if the PR fulfills these requirements

[x] Self-review: I am confident this is the simplest and clearest way to achieve the expected behaviour
[x] There are no dependencies on other PRs or I have linked dependencies through Zenhub
[x] The commit messages are clean and understandable
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Code runs on all relevant platforms (if major change: screenshots attached)

ephemer commented 6 years ago

Ok looks like this might work but it’s more of a workaround than something that’ll work for sure?