flowkey / UIKit-cross-platform

Cross-platform Swift implementation of UIKit, mostly for Android

MIT License

597 stars 40 forks source link

enable codeCoverage, setup codecov #234

Closed michaelknoch closed 5 years ago

michaelknoch commented 6 years ago

Type of change: improvement

Motivation

Trust is good, control is better

Please check if the PR fulfills these requirements

[ ] Self-review: I am confident this is the simplest and clearest way to achieve the expected behaviour
[ ] There are no dependencies on other PRs or I have linked dependencies through Zenhub
[ ] The commit messages are clean and understandable
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Code runs on all relevant platforms (if major change: screenshots attached)

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5aacce1). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #234   +/-   ##
=========================================
  Coverage          ?   51.92%           
=========================================
  Files             ?       87           
  Lines             ?     3168           
  Branches          ?        0           
=========================================
  Hits              ?     1645           
  Misses            ?     1523           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5aacce1...d57a34b. Read the comment docs.

michaelknoch commented 5 years ago

good question! @cshg

I'm not sure what change @ephemer actually requested. If we still wan't to measure our code coverage it would make sense for me to merge it.

cshg commented 5 years ago

@ephemer do you remember what changes you requested here?

michaelknoch commented 5 years ago

removed the tests @ephemer . you were right. I remember that i implemented those tests with the intention to improve coverage, not actually with the intention to prevent/fix bugs