Closed michaelknoch closed 5 years ago
:exclamation: No coverage uploaded for pull request base (
master@5aacce1
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #234 +/- ##
=========================================
Coverage ? 51.92%
=========================================
Files ? 87
Lines ? 3168
Branches ? 0
=========================================
Hits ? 1645
Misses ? 1523
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5aacce1...d57a34b. Read the comment docs.
good question! @cshg
I'm not sure what change @ephemer actually requested. If we still wan't to measure our code coverage it would make sense for me to merge it.
@ephemer do you remember what changes you requested here?
removed the tests @ephemer . you were right. I remember that i implemented those tests with the intention to improve coverage, not actually with the intention to prevent/fix bugs
Type of change: improvement
Motivation
Trust is good, control is better
Please check if the PR fulfills these requirements