flowkey / UIKit-cross-platform

Cross-platform Swift implementation of UIKit, mostly for Android

MIT License

594 stars 40 forks source link

update toolchain and fix deprecation warnings #303

Closed michaelknoch closed 3 years ago

michaelknoch commented 4 years ago

Type of change: dx

Motivation (current vs expected behavior)

update toolchain to latest master (faster incremental builds)
use new api for initializing JNIObjects (fixes a few deprecation warnings)
allow building demoapp for intel abi

Please check if the PR fulfills these requirements

[ ] Self-review: I am confident this is the simplest and clearest way to achieve the expected behaviour
[ ] There are no dependencies on other PRs or I have linked dependencies through Zenhub
[ ] The commit messages are clean and understandable
[ ] Tests for the changes have been added (for bug fixes / features)

codecov[bot] commented 4 years ago

Codecov Report

Merging #303 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   51.97%   51.97%           
=======================================
  Files          87       87           
  Lines        3161     3161           
=======================================
  Hits         1643     1643           
  Misses       1518     1518

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2de177...af17cc3. Read the comment docs.

michaelknoch commented 4 years ago

I think there is an even newer toolchain linked in current master. I can update this pr. the thing is, these changes in avplayer are currently crashing the player on startup. (Segmentation fault) @ephemer