flowkey / UIKit-cross-platform

Cross-platform Swift implementation of UIKit, mostly for Android
MIT License
594 stars 40 forks source link

explicitly set base sdk and supported platforms for UIKit mac target #304

Closed michaelknoch closed 4 years ago

michaelknoch commented 4 years ago

Type of change: dx

Motivation (current vs expected behavior)

This pr explicitly sets base sdk and supported platforms for the mac target to mac osx. Otherwise apples new build system gets confused when building a project which has a reference to UIKit-cross-platform. My guess is that this is a bug in the build system, because the values should already default to macos (thats at least what xcode is showing) but for some reason they fallback to ios which obviously makes no sense.

Please check if the PR fulfills these requirements

codecov[bot] commented 4 years ago

Codecov Report

Merging #304 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   51.97%   51.97%           
=======================================
  Files          87       87           
  Lines        3161     3161           
=======================================
  Hits         1643     1643           
  Misses       1518     1518

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bbc9b5d...8d8df8a. Read the comment docs.