Closed ephemer closed 1 year ago
Merging #311 into master will decrease coverage by
0.07%
. The diff coverage is16.66%
.
@@ Coverage Diff @@
## master #311 +/- ##
==========================================
- Coverage 51.42% 51.35% -0.08%
==========================================
Files 87 87
Lines 2872 2878 +6
==========================================
+ Hits 1477 1478 +1
- Misses 1395 1400 +5
Impacted Files | Coverage Δ | |
---|---|---|
Sources/UIWindow.swift | 61.11% <0.00%> (-7.64%) |
:arrow_down: |
Sources/UIScreen.swift | 11.42% <50.00%> (+0.74%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 65e5480...aae27ba. Read the comment docs.
I just had a look through the updated code and other than the code comment that I suggested we add this looks great to me 🚀 Feel free to press the button when you're ready!
Type of change: Graphical improvement
Motivation (current vs expected behavior)
We want to make UIWindow resizable depending on external factors. For example - by resizing the window on Mac, or by showing/hiding the status bar on Android, entering/leaving immersive mode etc.
Please check if the PR fulfills these requirements